Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-2.8] upgrade add-on framework to handle manifestwork size larger than 50k #1284

Open
wants to merge 1 commit into
base: release-2.8
Choose a base branch
from
Open

[release-2.8] upgrade add-on framework to handle manifestwork size larger than 50k #1284

wants to merge 1 commit into from

Conversation

subbarao-meduri
Copy link
Collaborator

Also upgrade sigs.k8s.io/controller-runtime to v0.14.4 for OCP 4.14 compatibility

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 13, 2023
View reviewed changes
collectors/metrics/pkg/logger/logger.go Fixed Show fixed Hide fixed
collectors/metrics/pkg/logger/logger.go Fixed Show fixed Hide fixed
collectors/metrics/pkg/logger/logger.go Fixed Show fixed Hide fixed
collectors/metrics/pkg/logger/logger.go Fixed Show fixed Hide fixed
@subbarao-meduri subbarao-meduri changed the title upgrade add-on framework to handle manifestwork size larger than 50k [release-2.8] upgrade add-on framework to handle manifestwork size larger than 50k Nov 15, 2023
@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability B 3 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

22.6% 22.6% Coverage
17.6% 17.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@openshift-ci openshift-ci bot added the lgtm label Nov 17, 2023
@philipgough
Copy link
Contributor

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: philipgough, subbarao-meduri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label May 18, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 18, 2024

New changes are detected. LGTM label has been removed.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
22.6% Coverage on New Code (required ≥ 70%)
B Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 18, 2024

@subbarao-meduri: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonarcloud e4adfed link true /test sonarcloud
ci/prow/test-e2e e4adfed link true /test test-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@philipgough
Copy link
Contributor

@subbarao-meduri should this be closed or merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipgough philipgough philipgough approved these changes

Assignees

@philipgough philipgough

Labels
approved dco-signoff: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@subbarao-meduri @philipgough